Skip to content

ES|QL Completion command syntax change #129189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2025
Merged

ES|QL Completion command syntax change #129189

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d0c8b0
Update completion command syntax (use = instead of AS)
afoucret Jun 10, 2025
572a0a7
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
afoucret Jun 10, 2025
8674cb7
Merge branch 'main' into esql-completion-command-syntax-change
afoucret Jun 10, 2025
7ff4847
Apply suggestions from code review
afoucret Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions x-pack/plugin/esql/qa/testFixtures/src/main/resources/completion.csv-spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ completion using a ROW source operator
required_capability: completion

ROW prompt="Who is Victor Hugo?"
| COMPLETION prompt WITH test_completion AS completion_output
| COMPLETION completion_output = prompt WITH test_completion
;

prompt:keyword | completion_output:keyword
Expand All @@ -18,7 +18,7 @@ completion using a ROW source operator and prompt is a multi-valued field
required_capability: completion

ROW prompt=["Answer the following question:", "Who is Victor Hugo?"]
| COMPLETION prompt WITH test_completion AS completion_output
| COMPLETION completion_output = prompt WITH test_completion
;

prompt:keyword | completion_output:keyword
Expand All @@ -34,7 +34,7 @@ FROM books METADATA _score
| WHERE title:"war and peace" AND author:"Tolstoy"
| SORT _score DESC
| LIMIT 2
| COMPLETION title WITH test_completion
| COMPLETION completion=title WITH test_completion
| KEEP title, completion
;

Expand All @@ -51,7 +51,7 @@ FROM books METADATA _score
| WHERE title:"war and peace" AND author:"Tolstoy"
| SORT _score DESC
| LIMIT 2
| COMPLETION CONCAT("This is a prompt: ", title) WITH test_completion
| COMPLETION completion=CONCAT("This is a prompt: ", title) WITH test_completion
| KEEP title, completion
;

Expand Down
240 changes: 120 additions & 120 deletions x-pack/plugin/esql/src/main/antlr/EsqlBaseLexer.tokens
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion x-pack/plugin/esql/src/main/antlr/EsqlBaseParser.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ rerankCommand
;

completionCommand
: COMPLETION prompt=primaryExpression WITH inferenceId=identifierOrParameter (AS targetField=qualifiedName)?
: COMPLETION (targetField=qualifiedName ASSIGN)? prompt=primaryExpression WITH inferenceId=identifierOrParameter
;

sampleCommand
Expand Down
Loading