Skip to content

Guard refresh against engine resets #129253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2025
Merged

Guard refresh against engine resets #129253

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d877eb8
Guard refresh against engine resets
tlrx Jun 11, 2025
baa1413
Merge branch 'main' into 2025/06/11/fix-3968
tlrx Jun 12, 2025
a182472
Merge commit '47032b5ab4bbbd4ed532fb6dfe0369ff9ef77cc7' into 2025/06/…
tlrx Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions server/src/main/java/org/elasticsearch/index/shard/IndexShard.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,12 +1326,15 @@ private Engine.GetResult innerGet(Engine.Get get, boolean translogOnly, Function
public Engine.RefreshResult refresh(String source) {
verifyNotClosed();
logger.trace("refresh with source [{}]", source);
return getEngine().refresh(source);
return withEngine(engine -> engine.refresh(source));
}

public void externalRefresh(String source, ActionListener<Engine.RefreshResult> listener) {
verifyNotClosed();
getEngine().externalRefresh(source, listener);
withEngine(engine -> {
engine.externalRefresh(source, listener);
return null;
});
}

/**
Expand Down