ShardSearchStatsTests - add missing metrics and methods #129311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
drempapis
added
Team:Search Foundations
elasticsearchmachine
removed
the
needs:triage
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
drempapis
changed the title
andreidan
approved these changes
Jun 20, 2025
Contributor
andreidan
left a comment
andreidan
left a comment
There was a problem hiding this comment.
Sorry for the delay Dimi.
LGTM, thanks for extending the test cases.
Contributor
Author
|
Thank you @andreidan and @pmpailis for the review |
kderusso
pushed a commit
to kderusso/elasticsearch
that referenced
this pull request
Jun 23, 2025
ShardSearchStatsTests - add missing metrics and methods - complete coverage
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
ShardSearchStatsTests - add missing metrics and methods - complete coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
ShardSearchStatsTestsclass only includes assertions for thegetSearchLoadRatemethod. This PR enhances the test coverage by adding assertions for the remainingSearchStatsmetrics, as well as introducing tests forreaderContextandscrollContext.