Skip to content

ESQL: Fix some more usages of field attribute names in LOOKUP JOIN #129355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jun 17, 2025
Merged

ESQL: Fix some more usages of field attribute names in LOOKUP JOIN #129355

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
08be01c
Fix some attr.name() usages that meant field names
alex-spies Jun 10, 2025
44dca94
Allow union type fields to be match fields
alex-spies Jun 10, 2025
35ed8ea
Improve some comments
alex-spies Jun 11, 2025
646f378
Add csv test for LU JOIN with union types
alex-spies Jun 11, 2025
e3ef5c2
[CI] Auto commit changes from spotless
Jun 12, 2025
8dfd4dc
Fix test compilation
alex-spies Jun 12, 2025
4858b1d
One more time
alex-spies Jun 13, 2025
4db8c81
Simplify setup in LookupJoinTypesIT
alex-spies Jun 13, 2025
a3da244
Refactor some more
alex-spies Jun 13, 2025
82d359b
Revert "Refactor some more"
alex-spies Jun 13, 2025
0a87d8b
Expand comment
alex-spies Jun 13, 2025
6634289
Refactor some more
alex-spies Jun 13, 2025
3470281
Refactor some more
alex-spies Jun 13, 2025
213f5df
Simplify TestConfigPasses
alex-spies Jun 13, 2025
77c5835
Add union type test cases to LookupJoinTypesIT
alex-spies Jun 13, 2025
7f98271
Merge remote-tracking branch 'upstream/main' into fix-lu-join-with-un…
alex-spies Jun 13, 2025
db3b5bb
Improve readability based on Fang's comments
alex-spies Jun 16, 2025
e86539b
Avoid HandleLimitFS in LookupJoinTypesIT
alex-spies Jun 16, 2025
9d4102e
[CI] Auto commit changes from spotless
Jun 16, 2025
bf01b0d
Merge remote-tracking branch 'upstream/main' into fix-lu-join-with-un…
alex-spies Jun 16, 2025
f0f4b48
Make naming more consistent
alex-spies Jun 16, 2025
3a8594e
Improve error message
alex-spies Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...l/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/LookupFromIndexIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
import org.elasticsearch.threadpool.ThreadPool;
import org.elasticsearch.xpack.core.async.AsyncExecutionId;
import org.elasticsearch.xpack.esql.core.expression.Alias;
import org.elasticsearch.xpack.esql.core.expression.FieldAttribute;
import org.elasticsearch.xpack.esql.core.expression.ReferenceAttribute;
import org.elasticsearch.xpack.esql.core.tree.Source;
import org.elasticsearch.xpack.esql.core.type.DataType;
Expand Down Expand Up @@ -229,7 +230,7 @@ private void runLookup(DataType keyType, PopulateIndices populateIndices) throws
keyType,
"lookup",
"lookup",
"key",
new FieldAttribute.FieldName("key"),
List.of(new Alias(Source.EMPTY, "l", new ReferenceAttribute(Source.EMPTY, "l", DataType.LONG))),
Source.EMPTY
);
Expand Down
Loading