Fix model settings propagation when merging semantic text fields #129438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that model settings are correctly set during mapping merges. While this is not an issue currently, since the underlying embedding field is not customizable, this fix is required for correct behavior in elastic#119967.
jimczi
added
>non-issue
auto-backport
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
added
the
Team:Search Relevance
kderusso
approved these changes
Jun 13, 2025
Member
kderusso
left a comment
kderusso
left a comment
There was a problem hiding this comment.
Thanks, I tested this with my branch and it does resolve the serialization issue
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
jimczi
removed
the
auto-backport
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Jun 13, 2025
…stic#129438) Ensure that model settings are correctly set during mapping merges. While this is not an issue currently, since the underlying embedding field is not customizable, this fix is required for correct behavior in elastic#119967.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that model settings are correctly set during mapping merges. While this is not an issue currently, since the underlying embedding field is not customizable, this fix is required for correct behavior in #119967.