- 
                Notifications
    
You must be signed in to change notification settings  - Fork 25.6k
 
FORK: Allow all processing commands #129465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
        
          
                x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/parser/StatementParserTests.java
          
            Show resolved
            Hide resolved
        
      | 
           Pinging @elastic/es-analytical-engine (Team:Analytics)  | 
    
| 
           Pinging @elastic/kibana-esql (ES|QL-ui)  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| | changePointCommand | ||
| | completionCommand | ||
| | grokCommand | ||
| : processingCommand | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we added fork initially, it was a goal to get to this point - well done!
        
          
                x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/parser/StatementParserTests.java
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only minor comments from me.
| assertThat(dissect.parser().pattern(), equalTo("%{d} %{e} %{f}")); | ||
| } | ||
| 
               | 
          ||
| public void testForkAllCommands() { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice test! I think it'll get stale over time - but that's not a problem as long as fork is plugged into the generative testing with other commands.
related: #126553
Allows all commands to be used in FORK branches.
We needed to make some adjustments to how we handle
)because otherwise using commands such asDROPin FORK branches caused errors such as:@idegtiarenko provided this example to visualize the problem.
we need to make sure we pop the
)while we are still inPROJECT_MODE:we needed to make these changes for all commands that can be part of FORK branches that don't use
EXPRESSION_MODE(which was handled here).