Fix project lookup in ILM task executor #129506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since elastic#129366 we obtain a `ProjectState` by using the `Index` to look up the project from the cluster state. However, when an index is deleted, that statement fails. Since we have no guaranteed way of determining which project a deleted index was from, we need to explicitly pass the `ProjectID` in the `IndexLifecycleClusterStateUpdateTask`s. Incidentally, we have to make parts of the `IndexLifecycleService` and `IndexLifecycleRunner` project-aware - but they'll likely need a follow-up PR to finish them. Fixes elastic#129489 Fixes elastic#129490 Fixes elastic#129491
nielsbauman
added
>non-issue
:Data Management/ILM+SLM
elasticsearchmachine
added
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Jun 30, 2025
These failing tests were already addressed in elastic#129506. Resolves elastic#129471 Resolves elastic#129479 Resolves elastic#129480 Resolves elastic#129481
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 30, 2025
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Jun 30, 2025
These failing tests were already addressed in elastic#129506. Resolves elastic#129471 Resolves elastic#129479 Resolves elastic#129480 Resolves elastic#129481
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 30, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
These failing tests were already addressed in elastic#129506. Resolves elastic#129471 Resolves elastic#129479 Resolves elastic#129480 Resolves elastic#129481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #129366 we obtain a
ProjectStateby using theIndexto look up the project from the cluster state. However, when an index is deleted, that statement fails. Since we have no guaranteed way of determining which project a deleted index was from, we need to explicitly pass theProjectIDin theIndexLifecycleClusterStateUpdateTasks.Incidentally, we have to make parts of the
IndexLifecycleServiceandIndexLifecycleRunnerproject-aware - but they'll likely need a follow-up PR to finish them.Fixes #129489
Fixes #129490
Fixes #129491
Fixes #129510