Skip to content

Rename shard heap to estimated heap #129514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2025
Merged

Rename shard heap to estimated heap #129514

merged 2 commits into from
Jun 17, 2025

Conversation

@ywangd
Copy link
Member

@ywangd ywangd commented Jun 17, 2025

Relates: ES-11445

@ywangd ywangd requested review from nicktindall and pxsalehi June 17, 2025 04:01
@ywangd ywangd requested a review from a team as a code owner June 17, 2025 04:01
@ywangd ywangd added :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >refactoring v9.1.0 labels Jun 17, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jun 17, 2025

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@elasticsearchmachine elasticsearchmachine added Team:Distributed Coordination Meta label for Distributed Coordination team serverless-linked Added by automation, don't add manually labels Jun 17, 2025
nicktindall
nicktindall approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@nicktindall nicktindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywangd ywangd added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jun 17, 2025
@elasticsearchmachine elasticsearchmachine merged commit d4981a4 into elastic:main Jun 17, 2025
24 checks passed
@ywangd ywangd deleted the rename-estimated-heap-usage branch June 17, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicktindall nicktindall nicktindall approved these changes

@pxsalehi pxsalehi pxsalehi approved these changes

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >refactoring serverless-linked Added by automation, don't add manually Team:Distributed Coordination Meta label for Distributed Coordination team v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ywangd @elasticsearchmachine @nicktindall @pxsalehi