Skip to content

Address when scores can be very large in osq score test #129592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025
Merged

Address when scores can be very large in osq score test #129592

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57722f4
Address when scores can be very large in osq score teset
benwtrent Jun 17, 2025
0498c2d
fixing abs diff
benwtrent Jun 18, 2025
b6a8b75
Merge branch 'main' into fix-osq-scorer-tests
benwtrent Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions .../test/java/org/elasticsearch/simdvec/internal/vectorization/ES91OSQVectorScorerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,21 @@ public void testScore() throws Exception {
scores2
);
for (int j = 0; j < ES91OSQVectorsScorer.BULK_SIZE; j++) {
if (scores1[j] > (maxDims * Short.MAX_VALUE)) {
int diff = (int) (scores1[j] - scores2[j]);
assertThat("defaultScores: " + scores1[j] + " bulkScores: " + scores2[j], Math.abs(diff), lessThan(65));
} else if (scores1[j] > (maxDims * Byte.MAX_VALUE)) {
int diff = (int) (scores1[j] - scores2[j]);
assertThat("defaultScores: " + scores1[j] + " bulkScores: " + scores2[j], Math.abs(diff), lessThan(9));
if (scores1[j] == scores2[j]) {
continue;
}
if (scores1[j] > (maxDims * Byte.MAX_VALUE)) {
float diff = Math.abs(scores1[j] - scores2[j]);
assertThat(
"defaultScores: " + scores1[j] + " bulkScores: " + scores2[j],
diff / scores1[j],
Copy link
Contributor

@john-wagster john-wagster Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this not need an Math.abs so as to be Math.abs(diff) / scores1[j]?

Copy link
Member Author

@benwtrent benwtrent Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right!

lessThan(1e-5f)
);
assertThat(
"defaultScores: " + scores1[j] + " bulkScores: " + scores2[j],
diff / scores2[j],
lessThan(1e-5f)
);
} else {
assertEquals(scores1[j], scores2[j], 1e-2f);
}
Expand Down