Skip to content

Force direct IO for fdt tmp file read access when flushing stored fields #129630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Force direct IO for fdt tmp file read access when flushing stored fields #129630

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0907c5d
Force direct IO for fdt tmp file read access when flushing stored fie…
martijnvg Jun 18, 2025
ccd1698
iter
martijnvg Jun 18, 2025
84ca40e
remove comment
martijnvg Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions server/src/main/java/org/elasticsearch/index/store/FsDirectoryFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,12 @@ protected boolean useDirectIO(String name, IOContext context, OptionalLong fileL

@Override
public IndexInput openInput(String name, IOContext context) throws IOException {
// Force direct I/O for stored field temp fdt files, given that these are used once and then removed:
// (tmp fdt files should only exist when index sorting is enabled)
if (directIODelegate != null && LuceneFilesExtensions.TMP.getExtension().equals(getExtension(name)) && name.contains("fdt")) {
return openInputDirect(name, context);
}

if (useDelegate(name, context)) {
// we need to do these checks on the outer directory since the inner doesn't know about pending deletes
ensureOpen();
Expand Down