Skip to content

Force normal read advice when reading fdt tmp files when flushing stored fields. #129634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Force normal read advice when reading fdt tmp files when flushing stored fields. #129634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions server/src/main/java/org/elasticsearch/index/store/FsDirectoryFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,13 @@ public IndexInput openInput(String name, IOContext context) throws IOException {
// we might run into trouble with files that are pendingDelete in one directory but still
// listed in listAll() from the other. We on the other hand don't want to list files from both dirs
// and intersect for perf reasons.

// Force normal read advice for stored field temp fdt files:
// (tmp fdt files should only exist when index sorting is enabled)
if (LuceneFilesExtensions.TMP.getExtension().equals(getExtension(name)) && name.contains("fdt")) {
context = context.withReadAdvice(ReadAdvice.NORMAL);
}

return delegate.openInput(name, context);
} else {
return super.openInput(name, context);
Expand Down