Fix for FORK branches with mixed outputs and unsupported field types #129636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #121950
Fixes an issue when FORK branches have different outputs which contain unsupported fields.
When a FORK branch is missing an column
Xthat is present in another branch, we add anEVAL X = nullto make sure all branches have the same output. We also align the attributes with a KEEP on each FORK branch.In the case where the indices we query have fields with mapping types that are not supported and the FORK branches have different outputs, we can get failures such as this:
This is because we add a
EVAL x = nullto the first branch, with x having anUNSUPPORTEDdata type.To fix this, we needed to make sure we don't break the current behaviour where if two branches have the same column name but with different types, we need to return a validation error.
For example, here we return a validation error and we need to preserve this behaviour:
returns: