ESQL: Add counters to signature for IS NULL
#129670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `counter_long` and `counter_double` to the signatures of supported fields for `IS NULL` and `IS NOT NULL`. We hadn't been generating those signatures since the docs v3 migration, so this had to plug those in. In addition, it changes the wording on a few things and adds a note that if a field is only in some documents then the ones missing the field will have `NULL` - which is important information for `IS NULL` and `IS NOT NULL`.
Contributor
|
🔍 Preview links for changed docs:
🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes. |
elasticsearchmachine
added
Team:Docs
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
leemthompo
reviewed
Jun 19, 2025
...in/esql/src/main/java/org/elasticsearch/xpack/esql/expression/predicate/nulls/IsNotNull.java
Outdated
Show resolved
Hide resolved
...lugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/predicate/nulls/IsNull.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@leemthompo - pushed a different description. |
leemthompo
reviewed
Jun 20, 2025
|
|
||
| public IsNotNull(Source source, Expression field) { | ||
| @FunctionInfo( | ||
| description = "Checks if a value *not* is `NULL`.", |
Contributor
There was a problem hiding this comment.
Suggested change
| description = "Checks if a value *not* is `NULL`.", | |
| description = "Checks if a value is *not* `NULL`.", |
leemthompo
approved these changes
Jun 20, 2025
Contributor
leemthompo
left a comment
leemthompo
left a comment
There was a problem hiding this comment.
LGTM with a remaining nit, thanks for thinking thru the wording changes :)
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
This adds `counter_long` and `counter_double` to the signatures of supported fields for `IS NULL` and `IS NOT NULL`. We hadn't been generating those signatures since the docs v3 migration, so this had to plug those in. In addition, it changes the wording on a few things and adds a note that if a field is only in some documents then the ones missing the field will have `NULL` - which is important information for `IS NULL` and `IS NOT NULL`.
Contributor
|
hey @nik9000 just checking if anything added in this PR represents a change in behavior for 9.1, which we should signal with the applies_to tags? I have a PR where I'm collecting updates, so I'll make the change if we need it :) |
Member
Author
|
Counters should be fine in all versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
counter_longandcounter_doubleto the signatures of supported fields forIS NULLandIS NOT NULL. We hadn't been generating those signatures since the docs v3 migration, so this had to plug those in. In addition, it changes the wording on a few things and adds a note that if a field is only in some documents then the ones missing the field will haveNULL- which is important information forIS NULLandIS NOT NULL.