Skip to content

[Test] Use default project s3 repo tests #129683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elasticsearchmachine merged 1 commit into from
Jun 19, 2025
Merged

[Test] Use default project s3 repo tests #129683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions modules/repository-s3/src/test/java/org/elasticsearch/repositories/s3/S3RepositoryTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,8 @@ public void testEmptyBucketName() {
}

private S3Repository createS3Repo(RepositoryMetadata metadata) {
final ProjectId projectId = randomProjectIdOrDefault();
final S3Repository s3Repository = new S3Repository(
projectId,
ProjectId.DEFAULT,
metadata,
NamedXContentRegistry.EMPTY,
new DummyS3Service(
Expand All @@ -181,7 +180,7 @@ private S3Repository createS3Repo(RepositoryMetadata metadata) {
new RecoverySettings(Settings.EMPTY, new ClusterSettings(Settings.EMPTY, ClusterSettings.BUILT_IN_CLUSTER_SETTINGS)),
S3RepositoriesMetrics.NOOP
);
assertThat(s3Repository.getProjectId(), equalTo(projectId));
assertThat(s3Repository.getProjectId(), equalTo(ProjectId.DEFAULT));
return s3Repository;
}

Expand Down