Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ public class ServiceAccountIT extends ESRestTestCase {
"indices": [
{
"names": [
"logs",
"logs.*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing that we also have metrics-* and traces-* here, should we also add metrics, metrics.*, traces and traces.*?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we only need for logs for now: elastic/kibana#224200 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we keep using the reroute processor I guess it is a matter of time to use it with metrics too. But ok, we can add it when this happens.

"logs-*",
"metrics-*",
"traces-*",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ final class ElasticServiceAccounts {
new RoleDescriptor.IndicesPrivileges[] {
RoleDescriptor.IndicesPrivileges.builder()
.indices(
"logs",
"logs.*",
"logs-*",
"metrics-*",
"traces-*",
Expand Down