Reduce max disk usage in IVFVectorsWriter during merging #129698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>non-issue
:Search Relevance/Search
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
kderusso
pushed a commit
to kderusso/elasticsearch
that referenced
this pull request
Jun 23, 2025
With this change we will create first the tmp file and the posting list and once the file is deleted we will merge the vectors on the vec file. Therefore we only have two copies of the vector at the same time.
julian-elastic
pushed a commit
to julian-elastic/elasticsearch
that referenced
this pull request
Jun 24, 2025
With this change we will create first the tmp file and the posting list and once the file is deleted we will merge the vectors on the vec file. Therefore we only have two copies of the vector at the same time.
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
With this change we will create first the tmp file and the posting list and once the file is deleted we will merge the vectors on the vec file. Therefore we only have two copies of the vector at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently merging the vectors on the .vec file and then copying the vectors to a tmp file for random access to generate the posting lists. In total we have three copies of the vector on disk at the same time.
With this change we will create first the tmp file and the posting list and once the file is deleted we will merge the vectors on the vec file. Therefore we only have two copies of the vector at the same time.