[ESQL] Shortcircuit grouping aggs on null value #129708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivancea
added
>non-issue
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
ivancea
commented
Jun 19, 2025
| } | ||
|
|
||
| var intArray = blockFactory.bigArrays().newIntArray(totalValues); | ||
| for (int i = 0; i < block.getPositionCount(); i++) { |
Contributor
Author
There was a problem hiding this comment.
This was a bug in the randomizer, which apparently wasn't triggering before
tylerperk
changed the title
luigidellaquila
approved these changes
Jul 2, 2025
| } | ||
|
|
||
| var intArray = blockFactory.bigArrays().newIntArray(totalValues); | ||
| for (int i = 0; i < block.getPositionCount(); i++) { |
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
Minor aggregators change plus a test to ensure we check that code path. We were doing a `value.isNull()` for each group the value had to be aggregated in, instead of doing it just once at the beginning. The affectation goes as follows: - 1 group, null value: We avoid some extra lightweight calls - N groups, null value: We avoid calling it N times - No groups, or non-null value: No effect
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
Minor aggregators change plus a test to ensure we check that code path. We were doing a `value.isNull()` for each group the value had to be aggregated in, instead of doing it just once at the beginning. The affectation goes as follows: - 1 group, null value: We avoid some extra lightweight calls - N groups, null value: We avoid calling it N times - No groups, or non-null value: No effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change plus a test to ensure we check that code path.
Basically, we were doing a
value.isNull()for each group the value had to be aggregated in, instead of doing it just once at the beginning.The affectation goes as follows:
I don't expect this to notably improve aggs, but it was something like a quick-win