Skip to content

[ESQL] Fix match phrase tests not being deterministic #129724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025
Merged

[ESQL] Fix match phrase tests not being deterministic #129724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75c773c
[ESQL] Fix match phrase tests not being deterministic
ivancea Jun 19, 2025
90d11d1
Merge branch 'main' into fix-esql-match-phrase-tests
ivancea Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,9 +568,6 @@ tests:
- class: org.elasticsearch.test.apmintegration.TracesApmIT
method: testApmIntegration
issue: https://github.com/elastic/elasticsearch/issues/129651
- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT
method: test {scoring.TestMatchPhraseWithScoreBoost ASYNC}
issue: https://github.com/elastic/elasticsearch/issues/129676
- class: org.elasticsearch.search.query.RescoreKnnVectorQueryIT
method: testKnnSearchRescore
issue: https://github.com/elastic/elasticsearch/issues/129713
Expand Down
10 changes: 6 additions & 4 deletions x-pack/plugin/esql/qa/testFixtures/src/main/resources/scoring.csv-spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,11 +567,12 @@ required_capability: metadata_score
from books metadata _score
| where match_phrase(title, "J. R. R. Tolkien")
| keep book_no, title, author, _score
| sort _score desc
;

book_no:keyword | title:text | author:text | _score:double
5335 | Letters of J R R Tolkien | J.R.R. Tolkien | 9.017186164855957
2130 | The J. R. R. Tolkien Audio Collection | [Christopher Tolkien, John Ronald Reuel Tolkien] | 8.412636756896973
5335 | Letters of J R R Tolkien | J.R.R. Tolkien | 9.017186164855957
2130 | The J. R. R. Tolkien Audio Collection | [Christopher Tolkien, John Ronald Reuel Tolkien] | 8.412636756896973
;

testMatchPhraseWithScoreBoost
Expand All @@ -580,9 +581,10 @@ required_capability: match_phrase_function
from books metadata _score
| where match_phrase(title, "J. R. R. Tolkien", {"boost": 5})
| keep book_no, title, author, _score
| sort _score desc
;

book_no:keyword | title:text | author:text | _score:double
5335 | Letters of J R R Tolkien | J.R.R. Tolkien | 45.0859260559082
2130 | The J. R. R. Tolkien Audio Collection | [Christopher Tolkien, John Ronald Reuel Tolkien] | 42.06318283081055
5335 | Letters of J R R Tolkien | J.R.R. Tolkien | 45.0859260559082
2130 | The J. R. R. Tolkien Audio Collection | [Christopher Tolkien, John Ronald Reuel Tolkien] | 42.06318283081055
;