Fix and unmute GetSnapshotsIT #129741
Merged
Fix and unmute GetSnapshotsIT #129741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: 129740
elasticsearchmachine
added
v9.1.0
needs:triage
Contributor
Author
nicktindall
commented
Jun 20, 2025
| // Allow the IN_PROGRESS snapshot to finish, then verify GET using SUCCESS has results and IN_PROGRESS does not. | ||
| // Do this in a finally, so the block doesn't interfere with teardown in the event of a failure | ||
| unblockAllDataNodes(repoName); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Just put this in a finally because I noticed when the block is applied and the test fails, it messes with the teardown.
nicktindall
commented
Jun 20, 2025
| assertThat(snapshots, hasSize(2)); | ||
| var states = snapshots.stream().map(SnapshotInfo::state).collect(Collectors.toSet()); | ||
| assertThat(states, hasItem(SnapshotState.SUCCESS)); | ||
| assertThat(states, hasItem(SnapshotState.IN_PROGRESS)); |
Contributor
Author
There was a problem hiding this comment.
use assertThat/hasItem to give a more detailed failure message
nicktindall
added
>test
elasticsearchmachine
added
the
Team:Distributed Coordination
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
elasticsearchmachine
removed
the
needs:triage
ywangd
approved these changes
Jun 20, 2025
Member
ywangd
left a comment
ywangd
left a comment
There was a problem hiding this comment.
LGTM
I suppose it should also work by blocking master node for finalizing the snapshot. Explicitly indexing more data also makes sense.
kderusso
pushed a commit
to kderusso/elasticsearch
that referenced
this pull request
Jun 23, 2025
Closes: 129740
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
Closes: 129740
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think because there was no new content since the last snapshot,
snapshot-in-progressnever got blocked by the repository block because it never went to the repository.Closes: #129740