Skip to content

Fix toIpInAgg & toIpInSort #129743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

Fix toIpInAgg & toIpInSort #129743

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
562270c
Fix toIpInAgg
idegtiarenko Jun 20, 2025
0116719
upd
idegtiarenko Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/plugin/esql/qa/testFixtures/src/main/resources/ip.csv-spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,15 +317,15 @@ FROM logs
2023-10-23T13:55:01.546Z| java|More java stuff |null
;

toIpInAgg
toIpInAgg#[skip:-8.12.99,reason:StatsNestedExp introduced in v8.13.0]
Copy link
Contributor Author

@idegtiarenko idegtiarenko Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This relies on #104387 added in 8.13

ROW s = "1.1.1.1" | STATS COUNT(*) BY ip = TO_IP(s)
;

COUNT(*):long | ip:ip
1 | 1.1.1.1
;

toIpInSort
toIpInSort#[skip:-8.13.99,reason:SortByExpression introduced in 8.14]
Copy link
Contributor Author

@idegtiarenko idegtiarenko Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This relies on #107158 added in 8.14

ROW s = "1.1.1.1" | SORT TO_IP(s)
;

Expand Down