ES|QL: Resolve Keep plan added to FORK branches #129754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioanatia
added
>non-issue
:Analytics/ES|QL
ioanatia
requested review from
ChrisHegarty,
carlosdelest,
luigidellaquila and
tteofili
carlosdelest
approved these changes
Jun 20, 2025
luigidellaquila
approved these changes
Jun 20, 2025
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
removed
the
Team:Search - Relevance
This was referenced Jun 20, 2025
kderusso
pushed a commit
to kderusso/elasticsearch
that referenced
this pull request
Jun 23, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#121950
fixes #129715
In order to align the output of FORK branches, we always add an explicit Keep plan at end of each branch.
However, we never actually resolve the KEEP plans we are adding.
KEEP can be unresolved in case it contains columns with unsupported or conflicting types.
Then we end up skipping validations in the verifier because the KEEP is unresolved:
elasticsearch/x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Verifier.java
Lines 109 to 113 in b2acda9