Skip to content

Mute testSnapshotRestore in bcUpgradeTest #129767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

Mute testSnapshotRestore in bcUpgradeTest #129767

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85a5aba
Mute testSnapshotRestore in bcUpgradeTest
ldematte Jun 20, 2025
1b0fe2d
Move filters to specific tasks
ldematte Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions build-tools-internal/src/main/groovy/elasticsearch.bc-upgrade-test.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,11 @@ tasks.register("bcUpgradeTest", StandaloneRestIntegTestTask) {
usesBwcDistribution(Version.fromString("0.0.0"))
systemProperty("tests.old_cluster_version", "0.0.0")
onlyIf("tests.bwc.main.version system property exists") { System.getProperty("tests.bwc.main.version") != null }
filter {
// Mute problematic tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add two words why those are problematic?

Copy link
Contributor Author

@ldematte ldematte Jun 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests use string compare of version (from the cluster, saved in the snapshot) with tests.bwc.main.version , which is far from ideal.
But I've investigated this a bit more, and I think we can fix this another way. See #129769
(ignore the IndexVersion change, it's there to test the change is working and will be reverted).

Still, in any case, this test assertion is.. not ideal. I'll contact distributed and see if they can do better.
@breskeby wdyt? Better to go with #129769, or mute these tests?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with muting. but as said we should do it in the build script rather than here in the plugin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move filters to the specific projects; is that what you were thinking? (have I done it right?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes thats what i meant :). Thank you.

excludeTestsMatching("org.elasticsearch.upgrades.FullClusterRestartIT.testSnapshotRestore")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those class specific filters should be defined on the specific task not within the plugin in general IMO. That makes it easier to detect those filters for other engineers directly in the according build script without the need to dig into the plugin logic.

excludeTestsMatching("org.elasticsearch.upgrades.FullClusterRestartIT.testSnapshotRestore *")
excludeTestsMatching("org.elasticsearch.xpack.restart.CoreFullClusterRestartIT.testSnapshotRestore")
excludeTestsMatching("org.elasticsearch.xpack.restart.CoreFullClusterRestartIT.testSnapshotRestore *")
}
}