-
Notifications
You must be signed in to change notification settings - Fork 25.5k
[DOCS][ESQL] GA search functions for 9.1 #129786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS][ESQL] GA search functions for 9.1 #129786
Conversation
Pinging @elastic/es-docs (Team:Docs) |
🔍 Preview links for changed docs: 🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes. |
- **rendered docs (md):** - kql: removed serverless preview, added ga 9.1.0 - match: removed serverless preview, added ga 9.1.0 - match_phrase: changed from preview 9.1.0 to unavailable 9.0 + ga 9.1.0 - qstr: removed serverless preview, added ga 9.1.0 - search functions list: removed bullet point before term function - **docs generation code (java):** - match_phrase: updated function info annotations to unavailable 9.0 + ga 9.1.0 - query_string: uncommented ga 9.1.0 annotation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM!
- removed `preview = true` from java function annotations for full-text search functions - generated updates to asciidoc and kibana docs - 8.x equivalent of elastic#129786
8.19 "backport": #129897 |
Promote ESQL search functions to GA in the docs - removed `preview = true` from java function annotations for full-text search functions - generated updates to asciidoc and kibana docs - 8.x equivalent of #129786
* [DOCS][ESQL] Flip preview booleans, to GA search functions * render docs, tweak some applies_to metadata in docs gen code - **rendered docs (md):** - kql: removed serverless preview, added ga 9.1.0 - match: removed serverless preview, added ga 9.1.0 - match_phrase: changed from preview 9.1.0 to unavailable 9.0 + ga 9.1.0 - qstr: removed serverless preview, added ga 9.1.0 - search functions list: removed bullet point before term function - **docs generation code (java):** - match_phrase: updated function info annotations to unavailable 9.0 + ga 9.1.0 - query_string: uncommented ga 9.1.0 annotation
```{applies_to} | ||
stack: preview 9.1.0 | ||
serverless: preview | ||
stack: unavailable 9.0, ga 9.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leemthompo I don't think we want to add an explicit unavailable
lifecycle state for states before a feature was available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shainaraskas New and interesting cans of worms everywhere! I understand, it's just a bit of an outlier that MATCH_PHRASE burst straight onto the scene in GA in 9.1.0 and so feels useful to know that it wasn't available in 9.0 like the other search functions. But maybe I was trying to wring more expressivity out of these lifecycles than they contain?
I'll rip it out
Replaces #128437
We required #128576 to actually generate the 9.1 docs with the correct
applies_to
tagging.Important
Notes for reviewer
If interested in the details of the metadata, please read up on
applies_to
.If checking the preview URLs, please note that how the applies_to tagging gets rendered will be updated soon, and this front-end stuff is managed by the docs build. Our job writing docs is to supply the correct versions and lifecycle information in the metadata in the docs source pages.
Also, just because something is marked "tech preview in 9.0" (for example) it doesn't necessarily mean it wasn't tech preview in previous 8.x versions. It's just that these docs on main are the 9.0+ docs and they don't talk about 8.x or below in the
applies_to
metadata.I'll open a manual "backport" equivalent to reflect the GA release on 8.x in a follow-up PR
cc @alex-spies this will be the official GAing PR