[IVF] Improve the format of the tmp file written during merging #129828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
benwtrent
approved these changes
Jun 23, 2025
Member
benwtrent
left a comment
benwtrent
left a comment
There was a problem hiding this comment.
I think separating out the doc ids vs the vectors is great!
kderusso
pushed a commit
to kderusso/elasticsearch
that referenced
this pull request
Jun 23, 2025
…tic#129828) This commit separe vector and docIds on the tmp file.
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
…tic#129828) This commit separe vector and docIds on the tmp file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During merging, we need to access the vectors in a random access fashion in order to build the clusters. In order to achieve that, we write our vectors and dicIds together on a temporary file. During testing on a memory constraint node, I noticed in the flamegraph that we were taking a lot of time reading docIds:
Looking at this process I noticed we can do much better because:
This commit just adds the logic above which improved the performance on memory constraint nodes.