ES|QL: Add number of max branches for FORK #129834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioanatia
added
>non-issue
:Analytics/ES|QL
tteofili
approved these changes
Jun 23, 2025
afoucret
approved these changes
Jun 23, 2025
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
removed
the
Team:Search - Relevance
ChrisHegarty
approved these changes
Jun 23, 2025
ioanatia
commented
Jun 23, 2025
| private int randomSizeForCollection(Class<? extends Node<?>> toBuildClass) { | ||
| int minCollectionLength = 0; | ||
| int maxCollectionLength = 10; | ||
| int maxCollectionLength = 8; |
Contributor
Author
There was a problem hiding this comment.
setting this to 8 for now which is the max number of FORK branches - I will follow up and improve this check so it's dependent on toBuildClass
Contributor
Author
|
serverless failures are unrelated to these changes |
23 tasks
kderusso
pushed a commit
to kderusso/elasticsearch
that referenced
this pull request
Jun 23, 2025
julian-elastic
pushed a commit
to julian-elastic/elasticsearch
that referenced
this pull request
Jun 24, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#121950
Add an implementation limit on the number of FORK branches.