Skip to content

Conversation

@kderusso
Copy link
Member

@kderusso kderusso commented Jun 23, 2025

This PR fixes an issue from #119967 where the default index_options were not displayed when include_defaults is set to true.

Part of this fix requires serializing the model_settings earlier so they're accessible when we're performing serialization checks for index_options.

Here is an example of how to test this:

PUT my-dense-semantic-index/
{
  "mappings": {
    "properties": {
      "inference_field": {
        "type": "semantic_text",
        "inference_id": "my-e5-model"
        }
      }
    }
  }
}

// Should not return index_options
GET my-dense-semantic-index/_mapping

// Returns BBQ hnsw default index_options
GET my-dense-semantic-index/_mapping/field/inference_field?include_defaults

@kderusso kderusso added >non-issue :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v8.19.0 auto-backport Automatically create backport pull requests when merged labels Jun 23, 2025
@kderusso
Copy link
Member Author

Closing as this introduces inconsistency in serialized models.

@kderusso kderusso closed this Jun 23, 2025
@kderusso kderusso deleted the kderusso/semantic-text-default-index-options branch June 24, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >non-issue :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants