-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Configurable Inference Timeout #129880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Samiul-TheSoccerFan
wants to merge
16
commits into
elastic:main
from
Samiul-TheSoccerFan:configurable-query-time-inference-timeout
Closed
Configurable Inference Timeout #129880
Samiul-TheSoccerFan
wants to merge
16
commits into
elastic:main
from
Samiul-TheSoccerFan:configurable-query-time-inference-timeout
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emantic query build
Mikep86
reviewed
Jun 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start! This initial commit gives us some useful info about what the scope of the solution should be:
- The inference timeout is also hard-coded for
sparse_vector(see here) andknn(see here) queries. Let's expand the scope to have one setting that controls the inference timeout for those + thesemanticquery inference timeout. - The machinations you had to go through to get the setting value for an individual index indicates that we should make this a cluster setting instead.
…uctor for testing purposes
|
closing in favor of #131551 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on introducing user configurable
inference timeoutsettings and use that as timeout during inference calls. Currently, it is hardcoded to10sand the goal is to make it configurable.Setup
GET the default settings:
Update the inference timeout value:
GET the updated settings: