[ES|QL] Change rounding mode in tests to HALF_DOWN #129895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current rounding mode in some of the tests in ESQL uses DOWN which truncates more than rounds and can result in some tests failing with errors like `row 0 column 0:0: expected <0.05235999> but was <0.05236>` HALF_DOWN would round this up
elasticsearchmachine
added
needs:triage
limotova
added
>test
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
dnhatn
added
v8.19.0
auto-backport
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 24, 2025
The current rounding mode in some of the tests in ESQL uses DOWN which truncates more than rounds and can result in some tests failing with errors like `row 0 column 0:0: expected <0.05235999> but was <0.05236>` HALF_DOWN would round this up
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
The current rounding mode in some of the tests in ESQL uses DOWN which truncates more than rounds and can result in some tests failing with errors like `row 0 column 0:0: expected <0.05235999> but was <0.05236>` HALF_DOWN would round this up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current rounding mode in some of the tests in ESQL uses DOWN which
truncates more than rounds and can result in some tests failing with
errors like
row 0 column 0:0: expected <0.05235999> but was <0.05236>HALF_DOWN would round this up.