Fix StatementParserTests #129898
Merged
Fix StatementParserTests #129898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes StatementParserTests.testPreserveParanthesis as it now depends on capability enabled only on snapshot builds
idegtiarenko
added
>test
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
commented
Jun 24, 2025
| public void testSubqueryWithPipe() { | ||
| assumeTrue("Requires EXPLAIN capability", EsqlCapabilities.Cap.EXPLAIN.isEnabled()); | ||
| assertEquals(new Explain(EMPTY, PROCESSING_CMD_INPUT), statement("explain ( row a = 1 )")); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
testSubquery and testSubqueryWithPipe are identical now. I am keeping only one of them.
luigidellaquila
approved these changes
Jun 24, 2025
Contributor
luigidellaquila
left a comment
luigidellaquila
left a comment
There was a problem hiding this comment.
Thanks @idegtiarenko, LGTM
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
This change fixes StatementParserTests.testPreserveParanthesis as it now depends on capability enabled only on snapshot builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes StatementParserTests.testPreserveParanthesis as it now depends on capability enabled only on snapshot builds
Closes: #129887
Related to: #129526