Skip to content

Fix for DenseVectorFieldMapperTests to properly initialize random vector given the dimensions in mappings #129912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 25, 2025
Merged

Fix for DenseVectorFieldMapperTests to properly initialize random vector given the dimensions in mappings #129912

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6c0ecec
fixing test setup after updates
pmpailis Jun 24, 2025
f1ed91c
Merge branch 'main' into fix_129911_DenseVectorFieldMapperTests
pmpailis Jun 24, 2025
818ec0d
Merge branch 'main' into fix_129911_DenseVectorFieldMapperTests
pmpailis Jun 24, 2025
b02f926
Update muted-tests.yml
pmpailis Jun 24, 2025
9e1a19b
Merge branch 'main' into fix_129911_DenseVectorFieldMapperTests
pmpailis Jun 24, 2025
2ee25c0
Merge branch 'main' into fix_129911_DenseVectorFieldMapperTests
pmpailis Jun 25, 2025
65c587d
Merge branch 'main' into fix_129911_DenseVectorFieldMapperTests
pmpailis Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,9 +565,6 @@ tests:
- class: org.elasticsearch.xpack.test.rest.XPackRestIT
method: test {p0=esql/60_usage/Basic ESQL usage output (telemetry) non-snapshot version}
issue: https://github.com/elastic/elasticsearch/issues/129888
- class: org.elasticsearch.index.mapper.vectors.DenseVectorFieldMapperTests
method: testExistsQueryMinimalMapping
issue: https://github.com/elastic/elasticsearch/issues/129911

# Examples:
#
Expand Down
13 changes: 12 additions & 1 deletion server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@

import static org.apache.lucene.codecs.lucene99.Lucene99HnswVectorsFormat.DEFAULT_BEAM_WIDTH;
import static org.apache.lucene.codecs.lucene99.Lucene99HnswVectorsFormat.DEFAULT_MAX_CONN;
import static org.apache.lucene.tests.index.BaseKnnVectorsFormatTestCase.randomNormalizedVector;
import static org.elasticsearch.index.codec.vectors.IVFVectorsFormat.DYNAMIC_NPROBE;
import static org.elasticsearch.index.mapper.vectors.DenseVectorFieldMapper.DEFAULT_OVERSAMPLE;
import static org.elasticsearch.index.mapper.vectors.DenseVectorFieldMapper.IVF_FORMAT;
Expand Down Expand Up @@ -147,7 +148,17 @@ private void indexMapping(XContentBuilder b, IndexVersion indexVersion) throws I

@Override
protected Object getSampleValueForDocument() {
return elementType == ElementType.FLOAT ? List.of(0.5, 0.5, 0.5, 0.5) : List.of((byte) 1, (byte) 1, (byte) 1, (byte) 1);
return elementType == ElementType.FLOAT
? convertToList(randomNormalizedVector(this.dims))
: List.of((byte) 1, (byte) 1, (byte) 1, (byte) 1);
}

private static List<Float> convertToList(float[] vector) {
List<Float> list = new ArrayList<>(vector.length);
for (float v : vector) {
list.add(v);
}
return list;
}

@Override
Expand Down