Fixing race condition in DynamicMappingIT when checking for updates in mappings #129931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmpailis
added
>test
elasticsearchmachine
added
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
benwtrent
approved these changes
Jun 24, 2025
Member
benwtrent
left a comment
benwtrent
left a comment
There was a problem hiding this comment.
I think this is good. After index, the mapping is updated asynchronously before the doc is indexed.
Maybe its better to have a "refresh=now" in the index request?
Though, we have ran into similar things in yaml tests. So, the assert busy is likely warranted.
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the linked issue, the following exception is only reproducible under heavy load, so I had to use
stress-nglocally to get some errors. It seems that there is a race condition in the tests, when we try to read the mappings before they actually have been updated by the ingested documents.Updated tests
testBBQDynamicMappingWhenFirstIngestingDocandtestDenseVectorDynamicMappingto use theassertBusypattern, similarly to other tests in the class.Closes #129928