Make ILMHistoryStore semi-project-aware
#129933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures the history store is able to index documents into a non-default project, but it doesn't actually work with multiple concurrent projects.
nielsbauman
added
>non-issue
:Data Management/ILM+SLM
nielsbauman
commented
Jun 24, 2025
Comment on lines
+186
to
+188
| // Even though this looks project-aware, it's not really. The bulk processor flushes the history items at "arbitrary" moments, | ||
| // meaning it will send bulk requests with history items of multiple projects, but the _bulk API will index everything into | ||
| // the project of the last history item that came in. |
Contributor
Author
There was a problem hiding this comment.
I plan to add an annotation and use it here before I merge this PR.
Member
There was a problem hiding this comment.
I guess the same conversation as on the other PR about assertions applies here?
elasticsearchmachine
added
v9.1.0
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Member
PeteGillinElastic
left a comment
PeteGillinElastic
left a comment
There was a problem hiding this comment.
LGTM pending the discussion on whether we can assert.
Comment on lines
+186
to
+188
| // Even though this looks project-aware, it's not really. The bulk processor flushes the history items at "arbitrary" moments, | ||
| // meaning it will send bulk requests with history items of multiple projects, but the _bulk API will index everything into | ||
| // the project of the last history item that came in. |
Member
There was a problem hiding this comment.
I guess the same conversation as on the other PR about assertions applies here?
PeteGillinElastic
approved these changes
Jun 27, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
Ensures the history store is able to index documents into a non-default project, but it doesn't actually work with multiple concurrent projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures the history store is able to index documents into a non-default project, but it doesn't actually work with multiple concurrent projects.