Allow ESQL extra verifiers to access settings #129954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
:Core/Infra/Core
elasticsearchmachine
added
Team:Core/Infra
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
added
the
serverless-linked
ldematte
approved these changes
Jun 25, 2025
Contributor
ldematte
left a comment
ldematte
left a comment
There was a problem hiding this comment.
This looks good for the Core/Infra part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request passes
SettingstoExtraCheckersso that we can condition these additional verifiers based on node setting values.Additionally, the existing integration tests for this have been removed, since they have been moved to serverless and we don't need to run the same tests twice.