Feature/prevent create api with cloud api key #129966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ud-api-key-authentication
…ud-api-key-authentication # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
…authentication # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
…ate-api-with-cloud-api-key # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authc/Authentication.java # x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/Security.java
elasticsearchmachine
added
needs:triage
...rc/main/java/org/elasticsearch/xpack/security/action/apikey/TransportCreateApiKeyAction.java
Outdated
Show resolved
Hide resolved
…ate-api-with-cloud-api-key
…cloud-api-key' into feature/prevent-create-api-with-cloud-api-key
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
elasticsearchmachine
removed
the
needs:triage
ankit--sethi
added
>non-issue
needs:triage
...plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/ApiKeyServiceTests.java
Outdated
Show resolved
Hide resolved
slobodanadamovic
approved these changes
Jun 26, 2025
Contributor
slobodanadamovic
left a comment
slobodanadamovic
left a comment
There was a problem hiding this comment.
LGTM 👍
(left a non blocking suggestion)
...plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/ApiKeyServiceTests.java
Outdated
Show resolved
Hide resolved
…ecurity/authc/ApiKeyServiceTests.java Co-authored-by: Slobodan Adamović <[email protected]>
…ecurity/authc/ApiKeyServiceTests.java Co-authored-by: Slobodan Adamović <[email protected]>
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
* [UIAM] Cloud API key authentication * Clean up * Nit * Fix more tests * Nit * Fix sig * Fix not * Nit * Authenticator * More * Javadoc * Javadoc * Fix tests * Exception handling * Javadoc * add new transport version * add todo to followup in ES-11961 * test cloud API key authentication serialization * add a validation * fix merge * fix merge * code review feedback + test * Update x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/ApiKeyServiceTests.java Co-authored-by: Slobodan Adamović <[email protected]> * Update x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/ApiKeyServiceTests.java Co-authored-by: Slobodan Adamović <[email protected]> * [CI] Auto commit changes from spotless --------- Co-authored-by: Nikolaj Volgushev <[email protected]> Co-authored-by: Slobodan Adamovic <[email protected]> Co-authored-by: Slobodan Adamović <[email protected]> Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not supporting this at this time per TDD