Fix ThreadPoolMergeExecutorServiceDiskSpaceTests testUnavailableBudgetBlocksNewMergeTasksFromStartingExecution #130001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
added
>test
elasticsearchmachine
added
Team:Distributed Indexing
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
albertzaharovits
added
the
auto-merge-without-approval
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Jun 26, 2025
…tBlocksNewMergeTasksFromStartingExecution (elastic#130001) The test might produce over-budget tasks that cannot run even if all the other tasks that were blocked (and hold up budget) while running complete. Rather than prevent submitting such over-budget tasks, this fix simply sets the merge task's queue available budget to `Long.MAX_VALUE`, in order to ensure that all merge tasks run before the test ends. Fixes elastic#129148
This was referenced Jun 26, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 26, 2025
…tBlocksNewMergeTasksFromStartingExecution (#130001) (#130110) The test might produce over-budget tasks that cannot run even if all the other tasks that were blocked (and hold up budget) while running complete. Rather than prevent submitting such over-budget tasks, this fix simply sets the merge task's queue available budget to `Long.MAX_VALUE`, in order to ensure that all merge tasks run before the test ends. Fixes #129148
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 26, 2025
…tBlocksNewMergeTasksFromStartingExecution (#130001) (#130107) The test might produce over-budget tasks that cannot run even if all the other tasks that were blocked (and hold up budget) while running complete. Rather than prevent submitting such over-budget tasks, this fix simply sets the merge task's queue available budget to `Long.MAX_VALUE`, in order to ensure that all merge tasks run before the test ends. Fixes #129148
Contributor
Author
|
The 9.1 branch was forked after this PR was merged into main: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test might produce over-budget tasks that cannot run even if all the other tasks that were blocked (and hold up budget) while running complete.
Rather than prevent submitting such over-budget tasks, this fix simply sets the merge task's queue available budget to
Long.MAX_VALUE, in order to ensure that all merge tasks run before the test ends.Fixes #129148