Skip to content

Turn direct IO for BBQ rescoring off by default #130014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 27, 2025
Merged

Turn direct IO for BBQ rescoring off by default #130014

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6e28282
Turn direct IO off by default
thecoop Jun 25, 2025
22adee0
Add changelog note for the directio option
thecoop Jun 25, 2025
4a5804c
Add check on the flag for tests
thecoop Jun 25, 2025
b8f17f0
Also disable direct IO test
thecoop Jun 26, 2025
2b4750e
Merge branch 'main' into disable-direct-io
thecoop Jun 26, 2025
ac493d8
Tweak wording
thecoop Jun 26, 2025
3b5d4e3
Merge branch 'main' into disable-direct-io
thecoop Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...n/java/org/elasticsearch/index/codec/vectors/es818/ES818BinaryQuantizedVectorsFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
*/
public class ES818BinaryQuantizedVectorsFormat extends FlatVectorsFormat {

static final boolean USE_DIRECT_IO = Boolean.parseBoolean(System.getProperty("vector.rescoring.directio", "true"));
static final boolean USE_DIRECT_IO = Boolean.parseBoolean(System.getProperty("vector.rescoring.directio", "false"));

public static final String BINARIZED_VECTOR_COMPONENT = "BVEC";
public static final String NAME = "ES818BinaryQuantizedVectorsFormat";
Expand Down