Skip to content

[ES|QL] Fix mapping for the colors CSV dataset (failing bwc tests) #130090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2025
Merged

[ES|QL] Fix mapping for the colors CSV dataset (failing bwc tests) #130090

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
209c631
Fix mapping for the colors CSV dataset.
afoucret Jun 26, 2025
7a1ad76
Adding explicit index options for the dense_vector dataset.
afoucret Jun 26, 2025
e3d01e9
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
afoucret Jun 26, 2025
57f5024
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
afoucret Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,8 +567,6 @@ tests:
- class: org.elasticsearch.xpack.inference.qa.mixed.CohereServiceMixedIT
method: testCohereEmbeddings
issue: https://github.com/elastic/elasticsearch/issues/130010
- class: org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT
issue: https://github.com/elastic/elasticsearch/issues/128224
- class: org.elasticsearch.xpack.autoscaling.storage.ReactiveStorageIT
method: testScaleDuringSplitOrClone
issue: https://github.com/elastic/elasticsearch/issues/130044
Expand Down
4 changes: 3 additions & 1 deletion x-pack/plugin/esql/qa/testFixtures/src/main/resources/mapping-colors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@
"type": "dense_vector",
"similarity": "l2_norm",
"index_options": {
"type": "hnsw"
"type": "hnsw",
"m": 16,
"ef_construction": 100
}
}
}
Expand Down
7 changes: 6 additions & 1 deletion x-pack/plugin/esql/qa/testFixtures/src/main/resources/mapping-dense_vector.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@
},
"vector": {
"type": "dense_vector",
"similarity": "l2_norm"
"similarity": "l2_norm",
"index_options": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ @alex-spies It seems that adding explicit index_options is preventing the failure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, great, thank you!

"type": "hnsw",
"m": 16,
"ef_construction": 100
}
}
}
}