This fixes a bug for non-docvalue numerics introduced in #128763 #130112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>bug
:Search Relevance/Search
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
mayya-sharipova
approved these changes
Jun 26, 2025
pmpailis
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to support more performant range queries, a refactor did a poor replacement for numeric fields that don't have doc-values.
PR #128763, instead of only replacing
LongFieldvalues also replaced a handful ofLongPointaccesses, which causes a failure assuming doc-values will be present, when they are not.This bug manifests when there are no doc values present for long or scaled float field. Users will receive a 500 failure mentioning:
This bug is not present in 8.19 or 9.1 as those versions updated to a new Lucene version and reverted the buggy patch.
related to: #128763
closes: #129995