Skip to content

Conversation

@idegtiarenko
Copy link
Contributor

This backports following changes to 8.19:

@idegtiarenko idegtiarenko requested a review from nik9000 June 27, 2025 11:14
@idegtiarenko idegtiarenko added backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL v8.19.0 labels Jun 27, 2025
@idegtiarenko idegtiarenko force-pushed the backport/8.19/pr-128828 branch from 77e9351 to 8ac7f20 Compare June 27, 2025 11:38
@idegtiarenko idegtiarenko marked this pull request as ready for review June 27, 2025 11:40
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Make sure you get the transport version in main first with the bwc parsing logic. Main is the source of truth for these numbers.

public static final TransportVersion ML_INFERENCE_ELASTIC_DENSE_TEXT_EMBEDDINGS_ADDED_8_19 = def(8_841_0_59);
public static final TransportVersion ML_INFERENCE_COHERE_API_VERSION_8_19 = def(8_841_0_60);
public static final TransportVersion ESQL_DOCUMENTS_FOUND_AND_VALUES_LOADED_8_19 = def(8_841_0_61);
public static final TransportVersion ESQL_PROFILE_INCLUDE_PLAN_8_19 = def(8_841_0_62);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be added in a PR to main first that include the isPatchFrom logic to parse it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, opened a pr for that: #130187

@idegtiarenko idegtiarenko merged commit 5f43af5 into elastic:8.19 Jun 30, 2025
22 checks passed
@idegtiarenko idegtiarenko deleted the backport/8.19/pr-128828 branch June 30, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.19.0 v8.19.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants