Skip to content

[Profiling] Ignore events count value #130293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
Merged

[Profiling] Ignore events count value #130293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4783f22
[Profiling] Ignore events count value
rockdaboot Jun 29, 2025
8b93b18
[CI] Auto commit changes from spotless
Jun 29, 2025
0240c79
Merge branch 'main' into profiling-ignore-count
rockdaboot Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ernalClusterTest/java/org/elasticsearch/xpack/profiling/action/GetFlameGraphActionIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ public void testGetStackTracesUnfiltered() throws Exception {
// only spot-check top level properties - detailed tests are done in unit tests
assertEquals(1008, response.getSize());
assertEquals(1.0d, response.getSamplingRate(), 0.001d);
assertEquals(46, response.getSelfCPU());
assertEquals(1995, response.getTotalCPU());
assertEquals(46, response.getTotalSamples());
assertEquals(45, response.getSelfCPU());
assertEquals(1974, response.getTotalCPU());
assertEquals(45, response.getTotalSamples());

// The root node's values are the same as the top-level values.
assertEquals("", response.getFileIds().get(0));
Expand Down
8 changes: 4 additions & 4 deletions ...rnalClusterTest/java/org/elasticsearch/xpack/profiling/action/GetStackTracesActionIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public void testGetStackTracesUnfiltered() throws Exception {
);
request.setAdjustSampleCount(true);
GetStackTracesResponse response = client().execute(GetStackTracesAction.INSTANCE, request).get();
assertEquals(46, response.getTotalSamples());
assertEquals(45, response.getTotalSamples());
assertEquals(1821, response.getTotalFrames());

assertNotNull(response.getStackTraceEvents());
Expand All @@ -47,7 +47,7 @@ public void testGetStackTracesUnfiltered() throws Exception {
"L7kj7UvlKbT-vN73el4faQ",
TransportGetStackTracesAction.DEFAULT_SAMPLING_FREQUENCY
);
assertEquals(3L, response.getStackTraceEvents().get(traceEventID).count);
assertEquals(2L, response.getStackTraceEvents().get(traceEventID).count);

assertNotNull(response.getStackTraces());
// just do a high-level spot check. Decoding is tested in unit-tests
Expand Down Expand Up @@ -85,7 +85,7 @@ public void testGetStackTracesGroupedByServiceName() throws Exception {
);
request.setAdjustSampleCount(true);
GetStackTracesResponse response = client().execute(GetStackTracesAction.INSTANCE, request).get();
assertEquals(46, response.getTotalSamples());
assertEquals(45, response.getTotalSamples());
assertEquals(1821, response.getTotalFrames());

assertNotNull(response.getStackTraceEvents());
Expand All @@ -97,7 +97,7 @@ public void testGetStackTracesGroupedByServiceName() throws Exception {
"L7kj7UvlKbT-vN73el4faQ",
TransportGetStackTracesAction.DEFAULT_SAMPLING_FREQUENCY
);
assertEquals(3L, response.getStackTraceEvents().get(traceEventID).count);
assertEquals(2L, response.getStackTraceEvents().get(traceEventID).count);
assertEquals(Long.valueOf(2L), response.getStackTraceEvents().get(traceEventID).subGroups.getCount("basket"));

assertNotNull(response.getStackTraces());
Expand Down
Loading