Fix a racing condition in shard snapshot status update #130302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enqueued task can run before the code reaches the status update line. When it happens, the status update can set the status backwards. This PR fixes it by moving the status update before enqueuing the task. Resolves: elastic#129752
ywangd
added
>test
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
elasticsearchmachine
added
the
Team:Distributed Coordination
ywangd
added
auto-merge-without-approval
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Member
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Jun 30, 2025
The enqueued task can run before the code reaches the status update line. When it happens, the status update can set the status backwards. This PR fixes it by moving the status update before enqueuing the task. Resolves: elastic#129752 (cherry picked from commit 6b0d534) # Conflicts: # muted-tests.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 1, 2025
…0368) The enqueued task can run before the code reaches the status update line. When it happens, the status update can set the status backwards. This PR fixes it by moving the status update before enqueuing the task. Resolves: #129752 (cherry picked from commit 6b0d534) # Conflicts: # muted-tests.yml
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
The enqueued task can run before the code reaches the status update line. When it happens, the status update can set the status backwards. This PR fixes it by moving the status update before enqueuing the task. Resolves: elastic#129752
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enqueued task can run before the code reaches the status update line. When it happens, the status update can set the status backwards. This PR fixes it by moving the status update before enqueuing the task.
Resolves: #129752