Remove tmp_fdt_no_mmap feature flag. #130308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After running this change for a week, no regressions where detected in nightly benchmarks that use index sorting.
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @martijnvg, I've created a changelog YAML for you. |
martijnvg
added
the
auto-backport
martijnvg
commented
Jun 30, 2025
| - class: org.elasticsearch.qa.verify_version_constants.VerifyVersionConstantsIT | ||
| method: testLuceneVersionConstant | ||
| issue: https://github.com/elastic/elasticsearch/issues/125638 | ||
| - class: org.elasticsearch.index.store.FsDirectoryFactoryTests |
Member
Author
There was a problem hiding this comment.
This test got muted, because of release test failures. I forgot to adjust the unit test to only run if feature flag (that will be removed via this pr) is enabled.
martijnvg
added
v8.19.1
v9.1.0
and removed
auto-backport
martijnvg
added
v9.1.1
auto-backport
Member
Author
|
Thanks @ChrisHegarty! |
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Jun 30, 2025
After running this change for a week, no regressions where detected in nightly benchmarks that use index sorting.
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 30, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
After running this change for a week, no regressions where detected in nightly benchmarks that use index sorting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running this change (#129538) for a week,
no regressions where detected in
nightly benchmarks that use index sorting.
While at the same time the median indexing throughput for logsdb with stored fields improved significantly:
https://elasticsearch-benchmarks.elastic.co/#tracks/logsdb/nightly/default/30d (nightly-elastic/logs-indexing-throughput)