ST_GEOHEX fix for excessive object creation in bounded grids #130343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigtaverner
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @craigtaverner, I've created a changelog YAML for you. |
craigtaverner
commented
Jul 1, 2025
|
|
||
| public GeoHashBoundedGrid(int precision, GeoBoundingBox bbox) { | ||
| private GeoHashBoundedGrid(int precision, GeoBoundingBox bbox) { | ||
| this.precision = checkPrecisionRange(precision); |
There was a problem hiding this comment.
This can be removed since it is checked in the factory earlier
Also fix an issue around nulls for out-of-bounds results And investigate and affirm that the use of -1 internally to mark invalid grid-ids is fine for all three grid types (ie. -1 is not a valid grid-id in any of these cases, for different reasons in each).
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
…#130343) Use new objects per thread instead of per record * Expand tests to use random bounds, after multi-thread fix * Also fix an issue around nulls for out-of-bounds results * And investigate and affirm that the use of -1 internally to mark invalid grid-ids is fine for all three grid types (ie. -1 is not a valid grid-id in any of these cases, for different reasons in each).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR at #125143 was creating a new object per record for bounded geo-hex grids, due to failures on serverless that appeared to be caused by race conditions in shared memory. It turns out the ES|QL evaluators already have a solution for this, so this PR fixes it to create a new object per evaluator, and the driver already ensures that each evaluator-tree is only used by either a single thread, or multiple threads in series, and never concurrently.