Fixed RRF YAML REST Test: rrf with pinned retriever as a sub-retriever
#130402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mridula-s109
added
auto-backport
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
|
Hi @mridula-s109, I've created a changelog YAML for you. |
mridula-s109
commented
Jul 1, 2025
...plugin/rank-rrf/src/yamlRestTest/resources/rest-api-spec/test/rrf/950_pinned_interaction.yml
Show resolved
Hide resolved
Mikep86
reviewed
Jul 1, 2025
...plugin/rank-rrf/src/yamlRestTest/resources/rest-api-spec/test/rrf/950_pinned_interaction.yml
Show resolved
Hide resolved
kderusso
reviewed
Jul 1, 2025
...plugin/rank-rrf/src/yamlRestTest/resources/rest-api-spec/test/rrf/950_pinned_interaction.yml
Show resolved
Hide resolved
mridula-s109
force-pushed
the
SEARCH-1080-yaml-test-failure-rrf-with-pinned-retriever-as-a-sub-retriever
branch
from
a4503f4 to
9125b38
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR un-mutes the 950_pinned_interaction.yml test and fixes its assertions by removing the default retriever, using match_none for the nested standard retriever, and updating the expected hits.
- Unmutes the failing YAML REST test for pinned sub-retriever
- Removes the initial standard retriever and replaces its nested query with
match_none - Updates assertions to expect only two pinned documents
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| x-pack/plugin/rank-rrf/src/yamlRestTest/resources/rest-api-spec/test/rrf/950_pinned_interaction.yml | Removed default retriever, replaced nested query with match_none, and updated hit assertions |
| muted-tests.yml | Removed mute entry for rrf with pinned retriever as a sub-retriever test |
Comments suppressed due to low confidence (2)
x-pack/plugin/rank-rrf/src/yamlRestTest/resources/rest-api-spec/test/rrf/950_pinned_interaction.yml:86
- [nitpick] Consider adding a brief comment explaining why
match_noneis used here to clarify that the default retriever should return no documents.
match_none: {}
x-pack/plugin/rank-rrf/src/yamlRestTest/resources/rest-api-spec/test/rrf/950_pinned_interaction.yml:88
- [nitpick] The test no longer verifies hit scores; consider re-adding an assertion for the expected scores or ordering to ensure scoring behavior is still correct.
- match: { hits.total.value: 2 }
Mikep86
reviewed
Jul 2, 2025
...plugin/rank-rrf/src/yamlRestTest/resources/rest-api-spec/test/rrf/950_pinned_interaction.yml
Outdated
Show resolved
Hide resolved
…d-retriever-as-a-sub-retriever
…d-retriever-as-a-sub-retriever
Mikep86
approved these changes
Jul 2, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
mridula-s109
added a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
…er` (elastic#130402) * fixed failing pinned retriever test * Update docs/changelog/130402.yaml * Delete docs/changelog/130402.yaml * Worked on the PR comments * Fixed the Match_none * space format * space format
mridula-s109
added a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 15, 2025
…er` (elastic#130402) * fixed failing pinned retriever test * Update docs/changelog/130402.yaml * Delete docs/changelog/130402.yaml * Worked on the PR comments * Fixed the Match_none * space format * space format # Conflicts: # muted-tests.yml
mridula-s109
added a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 15, 2025
…er` (elastic#130402) * fixed failing pinned retriever test * Update docs/changelog/130402.yaml * Delete docs/changelog/130402.yaml * Worked on the PR comments * Fixed the Match_none * space format * space format # Conflicts: # muted-tests.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How was this verified?