Prevent trace context propagation for self-rescheduling operations #130471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not create everlasting APM transactions
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
added
v9.2.0
serverless-linked
DaveCTurner
requested changes
Jul 2, 2025
There was a problem hiding this comment.
I would prefer that we make sure these tasks don't run in a tracing context right from the start (i.e. the point at which they're launched and conceptually detach themselves from the calling operation). The lack of tracing should then propagate automatically to the future-scheduled operations, as well as all the other operations that they run.
I'm ok with adding some assertions in these places to verify that we didn't accidentally start tracing anything, but it would be a bug to need to actually change the context each iteration as done here.
|
As discussed, closing this in favor of #130607 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent trace context propagation for self-rescheduling operations to not create everlasting APM transactions.
Relates to ES-10969