fix transport version conflict #130486
Merged
fix transport version conflict #130486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
merging without CI passing to fix the build in main. CI isn't going to pass without that. |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jul 2, 2025
We used to have an assertion during transport version loading that duplicate ids were not found, but it appears to have been lost in refactorings. This commit adds a test to ensure duplicate ids do not occur. relates elastic#130486
rjernst
added a commit
that referenced
this pull request
Jul 2, 2025
We used to have an assertion during transport version loading that duplicate ids were not found, but it appears to have been lost in refactorings. This commit adds a test to ensure duplicate ids do not occur. relates #130486
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jul 2, 2025
We used to have an assertion during transport version loading that duplicate ids were not found, but it appears to have been lost in refactorings. This commit adds a test to ensure duplicate ids do not occur. relates elastic#130486
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jul 2, 2025
We used to have an assertion during transport version loading that duplicate ids were not found, but it appears to have been lost in refactorings. This commit adds a test to ensure duplicate ids do not occur. relates elastic#130486
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jul 2, 2025
We used to have an assertion during transport version loading that duplicate ids were not found, but it appears to have been lost in refactorings. This commit adds a test to ensure duplicate ids do not occur. relates elastic#130486
This was referenced Jul 2, 2025
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jul 2, 2025
We used to have an assertion during transport version loading that duplicate ids were not found, but it appears to have been lost in refactorings. This commit adds a test to ensure duplicate ids do not occur. relates elastic#130486
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 2, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 2, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 3, 2025
* Test for duplicate transport versions (#130494) We used to have an assertion during transport version loading that duplicate ids were not found, but it appears to have been lost in refactorings. This commit adds a test to ensure duplicate ids do not occur. relates #130486 * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 3, 2025
* Test for duplicate transport versions (#130494) We used to have an assertion during transport version loading that duplicate ids were not found, but it appears to have been lost in refactorings. This commit adds a test to ensure duplicate ids do not occur. relates #130486 * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
elastic#129649 introduced a duplicate transport version. This fixes it.
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
We used to have an assertion during transport version loading that duplicate ids were not found, but it appears to have been lost in refactorings. This commit adds a test to ensure duplicate ids do not occur. relates elastic#130486
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#129649 introduced a duplicate transport version. This fixes it.