Executing shard recovery in project context #130525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.2.0
serverless-linked
ywangd
added
>non-issue
:Distributed Indexing/Recovery
elasticsearchmachine
added
the
Team:Distributed Indexing
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
pxsalehi
reviewed
Jul 14, 2025
| IndexShard indexShard = indexService.createShard(shardRouting, globalCheckpointSyncer, retentionLeaseSyncer); | ||
| indexShard.addShardFailureCallback(onShardFailure); | ||
| indexShard.startRecovery( | ||
| final CheckedRunnable<RuntimeException> recoveryRunnable = () -> indexShard.startRecovery( |
There was a problem hiding this comment.
Using RuntimeException for CheckedRunnable doesn't seem right. Maybe just inline the indexShard.startRecovery?
There was a problem hiding this comment.
Sure I inlined it. It is still an RuntimeException underlyingly. But at least we don't see it. I was trying to minimize the format changes. But it is pretty minimal either way.
|
@pxsalehi I could still use your approval on this stateful side of PR. Thanks! |
pxsalehi
approved these changes
Jul 18, 2025
ywangd
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title