Skip to content

IVFVectorsFormat doesn't report off-heap stats at the moment #130553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2025
Merged

IVFVectorsFormat doesn't report off-heap stats at the moment #130553

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
024301f
IVFVectorsFormat doesn't report off-heap stats at the moment
thecoop Jul 3, 2025
aaaab6e
[CI] Auto commit changes from spotless
Jul 3, 2025
26529b3
Merge branch 'lucene_snapshot' into ivf-vectors-format-offheap-stats
thecoop Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions server/src/test/java/org/elasticsearch/index/codec/vectors/IVFVectorsFormatTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@
import static java.lang.String.format;
import static org.elasticsearch.index.codec.vectors.IVFVectorsFormat.MAX_VECTORS_PER_CLUSTER;
import static org.elasticsearch.index.codec.vectors.IVFVectorsFormat.MIN_VECTORS_PER_CLUSTER;
import static org.hamcrest.Matchers.anEmptyMap;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.oneOf;

Expand Down Expand Up @@ -83,6 +85,25 @@ protected Codec getCodec() {
return TestUtil.alwaysKnnVectorsFormat(format);
}

@Override
protected void assertOffHeapByteSize(LeafReader r, String fieldName) throws IOException {
var fieldInfo = r.getFieldInfos().fieldInfo(fieldName);

if (r instanceof CodecReader codecReader) {
KnnVectorsReader knnVectorsReader = codecReader.getVectorReader();
if (knnVectorsReader instanceof PerFieldKnnVectorsFormat.FieldsReader fieldsReader) {
knnVectorsReader = fieldsReader.getFieldReader(fieldName);
}
var offHeap = knnVectorsReader.getOffHeapByteSize(fieldInfo);
long totalByteSize = offHeap.values().stream().mapToLong(Long::longValue).sum();
// IVF doesn't report stats at the moment
assertThat(offHeap, anEmptyMap());
assertThat(totalByteSize, equalTo(0L));
} else {
throw new AssertionError("unexpected:" + r.getClass());
}
}

@Override
public void testAdvance() throws Exception {
// TODO re-enable with hierarchical IVF, clustering as it is is flaky
Expand Down