Skip to content

Fix Netty4HttpServerTransportTests if run with FIPS and entitlements #130616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 4, 2025
Merged

Fix Netty4HttpServerTransportTests if run with FIPS and entitlements #130616

merged 5 commits into from
Jul 4, 2025

Conversation

@mosche
Copy link
Contributor

@mosche mosche commented Jul 4, 2025 •
edited
Loading

In this case org.bouncycastle.jsse.provider needs to be considered a test library so we can create the appropriate request.
Configuring test libraries in a better way needs to be looked at in ES-12128.

Fixes #130591
Fixes #130590
Fixes #130589
Fixes #130588
Fixes #130587
Fixes #130586
Fixes #130585
Fixes #130584
Fixes #130517
Fixes #130519

@mosche mosche requested a review from a team July 4, 2025 09:40
@mosche mosche added >test Issues or PRs that are addressing/adding tests :Core/Infra/Entitlements Entitlements infrastructure labels Jul 4, 2025
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team v9.2.0 labels Jul 4, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

ldematte
ldematte approved these changes Jul 4, 2025
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided CI passes

@n1v0lg
Copy link
Contributor

n1v0lg commented Jul 4, 2025

Nice! I'm wondering if this also fixes:

Checking now

@n1v0lg
Copy link
Contributor

n1v0lg commented Jul 4, 2025

@mosche I think we need test-fips label here to run the tests in fips mode

@n1v0lg n1v0lg added the test-fips Trigger CI checks for FIPS label Jul 4, 2025
n1v0lg
n1v0lg reviewed Jul 4, 2025
View reviewed changes
@n1v0lg n1v0lg mentioned this pull request Jul 4, 2025
Closed
@mosche mosche added v8.19.0 v9.1.1 auto-backport Automatically create backport pull requests when merged labels Jul 4, 2025
n1v0lg
n1v0lg approved these changes Jul 4, 2025
View reviewed changes
Copy link
Contributor

@n1v0lg n1v0lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@mosche mosche merged commit b35e97e into elastic:main Jul 4, 2025
39 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.19 Commit could not be cherrypicked due to conflicts
❌ 9.1 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 130616

This was referenced Jul 4, 2025
Closed
Closed
Closed
Closed
Closed
Closed
@n1v0lg n1v0lg mentioned this pull request Jul 6, 2025
Closed
@mosche mosche mentioned this pull request Jul 7, 2025
Merged
mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 7, 2025
@mosche
Fix various test to run with FIPS and entitlements (elastic#130616)
f5d2524 
(cherry picked from commit b35e97e)

# Conflicts:
#	muted-tests.yml
@mosche mosche mentioned this pull request Jul 7, 2025
Merged
@mosche
Copy link
Contributor Author

mosche commented Jul 7, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.1
✅ 8.19

Questions ?

Please refer to the Backport tool documentation

mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 7, 2025
@mosche
Fix various test to run with FIPS and entitlements (elastic#130616)
f6a7eb0 
(cherry picked from commit b35e97e)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Jul 7, 2025
@mosche
Fix various test to run with FIPS and entitlements (#130616) (#130686)
04e1f93 
(cherry picked from commit b35e97e)

# Conflicts:
#	muted-tests.yml
mosche added a commit that referenced this pull request Jul 7, 2025
@mosche
Fix various test to run with FIPS and entitlements (#130616) (#130687)
fb2990f 
(cherry picked from commit b35e97e)
@n1v0lg n1v0lg mentioned this pull request Jul 7, 2025
Closed
This was referenced Jul 8, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldematte ldematte ldematte approved these changes

@n1v0lg n1v0lg n1v0lg approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged backport pending :Core/Infra/Entitlements Entitlements infrastructure Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests test-fips Trigger CI checks for FIPS v8.19.0 v9.1.1 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] ReindexRestClientSslTests testClientSucceedsWithCertificateAuthorities failing [CI] ReindexRestClientSslTests testClientFailsWithUntrustedCertificate failing [CI] ReindexRestClientSslTests testClientPassesClientCertificate failing [CI] DefaultJdkTrustConfigTests testGetNonPKCS11TrustStoreWithPasswordSet failing [CI] DefaultJdkTrustConfigTests testGetSystemTrustStoreWithNoSystemProperties failing
[CI] ReindexFromRemoteBuildRestClientTests testHeaders failing [CI] ReindexFromRemoteBuildRestClientTests testBuildRestClient failing [CI] RemoteScrollableHitSourceTests class failing [CI] Netty4HttpServerTransportTests testRespondAfterServiceCloseWithClientCancel failing [CI] Netty4HttpServerTransportTests testRespondAfterServiceCloseWithServerCancel failing

4 participants

@mosche @elasticsearchmachine @n1v0lg @ldematte