Skip to content

Refactor JDKVectorLibraryTests to JDKVectorLibraryInt7uTests #130617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2025
Merged

Refactor JDKVectorLibraryTests to JDKVectorLibraryInt7uTests #130617

merged 2 commits into from
Jul 4, 2025

Conversation

@ChrisHegarty
Copy link
Contributor

This commit refactors JDKVectorLibraryTests to JDKVectorLibraryInt7uTests, in order to make space for other vector scorer benchmarks, namely float32.

@ChrisHegarty ChrisHegarty requested a review from ldematte July 4, 2025 09:45
@ChrisHegarty ChrisHegarty requested a review from a team as a code owner July 4, 2025 09:45
@ChrisHegarty ChrisHegarty added >refactoring :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.2.0 v8.19.1 labels Jul 4, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@ChrisHegarty ChrisHegarty added the test-arm Pull Requests that should be tested against arm agents label Jul 4, 2025
@ChrisHegarty ChrisHegarty added the test-windows Trigger CI checks on Windows label Jul 4, 2025
ldematte
ldematte approved these changes Jul 4, 2025
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHegarty ChrisHegarty added >test Issues or PRs that are addressing/adding tests v9.1.1 auto-backport Automatically create backport pull requests when merged labels Jul 4, 2025
@ChrisHegarty ChrisHegarty merged commit 20ef955 into elastic:main Jul 4, 2025
38 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 9.1 Commit could not be cherrypicked due to conflicts
❌ 8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 130617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldematte ldematte ldematte approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged backport pending >refactoring :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests test-arm Pull Requests that should be tested against arm agents test-windows Trigger CI checks on Windows v8.19.1 v9.1.1 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChrisHegarty @elasticsearchmachine @ldematte